Abstract mobile transition interactions #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR brought to you by a late night and a bottle of red wine |
novaugust
force-pushed
the
issue4032
branch
2 times, most recently
from
8b498f1 to
4e664e4
Compare
| }); | ||
| if (post) { | ||
| return self.transitionTo('posts.post', post); | ||
| } | ||
| else { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@novaugust Seems to be a good bottle :) Nice refactoring / implementation of mobile transitions. |
|
Epic! 😁 |
Closes TryGhost#4032 - Created "mobile" views: `parent-view`, `content-view` and `index-view` - `mobile/parent-view` has three callbacks for managing layout, and a mediaQuery listener to keep in sync with the user - content-view and index-view use their parent-views callbacks to bring themselves into and out of the viewport as appropriate - fixed media queries for post content list from 800px to 900px - Created `mobile-index-route` to intelligently transition to a new route on desktops (used by both PostsIndexRoute and SettingsIndexRoute) - Extract mobile interactions from settings views to new mobile utility views - `js-` prefixed settings view transitions - removed unused openEditor action from PostsRoute - removed unused mobile util "responsiveAction"
novaugust
force-pushed
the
issue4032
branch
from
4e664e4 to
09fb17a
Compare
|
LGTM! 👍 |
|
@ErisDS that's something completely separate from this, where each settings subroute has some complex logic to add and remove specific classnames. I don't think it belongs with this pr. |
|
I totes misunderstood what was meant by
|
ErisDS
added a commit
that referenced
this pull request
Sep 16, 2014
Abstract mobile transition interactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4032, ref #3950's "epic goal"
parent-view,content-viewandindex-viewmobile/parent-viewhas three callbacks for managing layout, and a mediaQuery listener to keep in sync with the usermobile-index-routeto intelligently transition to a new route on desktops (used by both PostsIndexRoute and SettingsIndexRoute)