Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Management UI Markup #4171

Merged
merged 1 commit into from
Oct 1, 2014
Merged

Tag Management UI Markup #4171

merged 1 commit into from
Oct 1, 2014

Conversation

PaulAdamDavis
Copy link
Member

References #3926

Static markup for the Tag Management screen

A few notes:

  • Clicking the tag title now opens a settings menu on the right hand side, much like the new post settings menu
  • The settings menu is also used when adding a new tag, only the delete button isn't there and 'Edit Tag' says 'New Tag'
  • Search will not be included in the first implementation of this
  • As with the post settings menu, clicking outside of the menu closes it
  • The markup is dependent on child tags being nested inside its parent. This makes them infinitely scalable.
<div class="tag">
    ...
    <div class="tag">
        ...
    </div>
</div>

@JohnONolan
Copy link
Member

@paul - the down-right-arrow thing is a bit ugly (as in, my fault for making it ugly) - wondering if we might not be better off with just a couple of thin CSS lines instead. Whatchoo think?

@PaulAdamDavis
Copy link
Member Author

@JohnONolan Completely agree RE down right arrow. I've updated this inline with your comments and a new css-only arrow.

screen shot 2014-09-30 at 22 42 16

References #3926

Static markup for the Tag Management screen
JohnONolan added a commit that referenced this pull request Oct 1, 2014
@JohnONolan JohnONolan merged commit 319470d into TryGhost:master Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants