Tags management api hookup #4489
Conversation
|
I'm 100% sure there's fiddly bits that aren't in, and that these notifications aren't final products. I just wanted to get another step forward on this. |
| @@ -14,11 +14,11 @@ | |||
| </header> | |||
|
|
|||
| <section class="content settings-tags"> | |||
| {{#each}} | |||
| {{#each tag in tags}} | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
novaugust
force-pushed
the
tags-client-basics
branch
from
40682b6 to
19b8b3c
Compare
|
Button'd |
|
The bug with the Set |
|
So I've taken this for a spin, and it's looking pretty darned sweet! I've now written up the vision for tags here - and am moving the spec for the minimum shippable version into #4248 and some sub issues. This has a lot of it covered already. We want to remove the visibility and hierarchy features for now and ship it looking like this: I suggest ripping out the parent and visibility drop downs, and updating the tag name label to be just 'name' in this PR. Then I'll open sub issues to cover:
Sound good? |
|
Sounds great. |
novaugust
force-pushed
the
tags-client-basics
branch
from
19b8b3c to
70cf481
Compare
novaugust
changed the title
novaugust
force-pushed
the
tags-client-basics
branch
from
70cf481 to
eae9525
Compare
|
Sorry for being slow. What happened to the image uploader? Also, can we lose the search button? |
|
Images: Deleted it - didn't think the tags model supported images currently? |
|
I see that I am mistaken though. I'll bring it back in, but won't have time to hook it up until Monday |
novaugust
force-pushed
the
tags-client-basics
branch
from
eae9525 to
bd0f5e0
Compare
Ref TryGhost#4248 - Added tags settings menu - Added basic new, edit, delete, and save actions - Show actionable edit buttons dynamically based on tag state - Infinite scroll - Closing the tag settings menu rollbacks your changes - Removed not-yet-implementable code
Ref #4248