Sort newest to oldest in sitemap files #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes TryGhost#4611 Refactored generateXmlFromNodes to pull the urlElements itself from sorted values in the lookup Added some checks to existing unit tests to validate ordering.
|
I wouldn't doubt that it's just me but I'm testing this and it seems like the listings are still being sorted oldest -> newest. Maybe I'm wrong but my assumption was that the sitemaps are in-memory and restarting Ghost would trigger a refresh/rebuild? |
|
@jaswilli They are in memory, but shouldn't need a restart to update. Let me double check; I relied on the unit test with the order check but didn't test thoroughly while adding/updating/removing posts live on my dev site. |
|
@jgable sorry, I was focusing on |
jaswilli
added a commit
that referenced
this pull request
Dec 10, 2014
Sort newest to oldest in sitemap files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4611
Refactored generateXmlFromNodes to pull the urlElements itself from sorted values in the lookup.
Added some checks to existing unit tests to validate ordering.