Add support for importing images #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisDS
force-pushed
the
image-importer
branch
2 times, most recently
from
ce680e1 to
2ad7eca
Compare
|
Awkward moment there where it turns out one of the previous tests is overriding the config and not resetting it, but got it fixed, should pass this time. |
closes TryGhost#4608, TryGhost#4609 - image handler loads in any image files & figures out where they'll get stored - image importer has a preprocessor which replaces image paths in pertinent spots of post, tag and user models - image importer stores images, keeping the path where it makes sense - basic test for the preprocessor
ErisDS
force-pushed
the
image-importer
branch
from
2ad7eca to
ba3d4b3
Compare
jaswilli
added a commit
that referenced
this pull request
Dec 24, 2014
Add support for importing images
ErisDS
added a commit
to ErisDS/Ghost
that referenced
this pull request
Jan 2, 2015
ref TryGhost#4608, TryGhost#4609, TryGhost#4690 - fix errors with cleaning up files - improve handling of base directories, and introduce a simple valid format for zips (must contain importable files or folders, and may contain up to one base directory) - vastly improve test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4608, #4609
pertinent spots of post, tag and user models