Refactor main nav menu into components #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaswilli
commented
May 24, 2015
jaswilli
commented
- Nav menu is now composed from a set of components.
- Gets rid of all jquery from the nav menu behaviors.
- If autonav is enabled the close behavior now works properly if a settings menu is also open.
- If autonav is enabled dropdown menus are closed when the nav menu closes.
- Remove unused computed properties for user images from Application controller.
ErisDS
added a commit
that referenced
this pull request
May 25, 2015
Refactor main nav menu into components
This was referenced Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.