Switch channel filters to use strings not literals #6251
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes TryGhost#6247 - GQL has a bug where literals starting with numbers are incorrectly parsed - Using strings instead of literals is a workaround, but is probably safer anyway
|
As commented on the issue, this is effectively a quick fix. It's still probably the right thing to do, as using a proper quoted string is safer than a literal and literals are really intended for developer ease when using the The underlying bug in GQL is not a quick thing to resolve, so I'll probably partner this PR with some updates to the documentation to make using strings more prominent. |
sebgie
added a commit
that referenced
this pull request
Dec 21, 2015
Switch channel filters to use strings not literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6247