Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] New mobiledoc based editor #6255

Closed
wants to merge 4 commits into from

Conversation

kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented Dec 21, 2015

prereq for TryGhost/Admin#6

Spike/prototype to test out new editor functionality based around https://github.com/bustlelabs/mobiledoc-kit

no issue

  • adds server-side mobiledoc rendering
  • adds support for demo SimpleMDE markdown card

@halfdan
Copy link
Contributor

halfdan commented Dec 21, 2015

Do I understand this correct as a step away from Markdown? Or is there a plan to allow the new editor to handle Markdown? Or in other words - how does Ghost looks like after this PR?

@ErisDS
Copy link
Member

ErisDS commented Dec 21, 2015

This is an experiment that aims to answer all of those questions. As I said to you in Slack the other day, we're planning right now - and that comes with some experimenting. It's a chicken-and-egg kinda situation.

@kevinansfield
Copy link
Member Author

Do I understand this correct as a step away from Markdown? Or is there a plan to allow the new editor to handle Markdown?

There are a couple of immediate options:

  1. The mobiledoc editor already recognizes some markdown and automatically converts the text (such as lists etc) as you type and it's easy to extend with other text expansions so it would still be possible to type markdown to some extent
  2. There is support for "cards" that are like editable sections with a HTML/text/dom renderer - it should be fairly simple to have a "markdown" card that ingests markdown formatted text and uses an existing markdown converter for it's HTML renderer. In this way there could even be multiple community markdown cards that use different markdown libraries

Although markdown should still be easy to support, the idea with the new editor is to move away from the restrictions that markdown imposes and open up a new level of flexibility/extensibility. However as @ErisDS said there's still a lot of experimentation to be done in that regard 😄

@nuclearpengy
Copy link

Sounds interesting.

ErisDS added a commit to ErisDS/Ghost that referenced this pull request Feb 16, 2016
refs TryGhost#6301, TryGhost#6165, TryGhost#6255

- Adds a new mobiledoc field to posts for the new editor spike, with a long text field
- Removes the tags.hidden field.
- Adds a new 'visibility' field to the 3 main models: Post, Tag, User for general purpose use with any feature which modifies where and when an object can be viewed
ErisDS added a commit to ErisDS/Ghost that referenced this pull request Feb 16, 2016
refs TryGhost#6301, TryGhost#6165, TryGhost#6255

- Adds a new mobiledoc field to posts for the new editor spike, with a long text field
- Removes the tags.hidden field.
- Adds a new 'visibility' field to the 3 main models: Post, Tag, User for general purpose use with any feature which modifies where and when an object can be viewed
@dbalders dbalders mentioned this pull request Apr 5, 2016
13 tasks
ErisDS added a commit to ErisDS/Ghost that referenced this pull request Apr 14, 2016
refs TryGhost#6301, TryGhost#6255

- new, extra-long, column for storing mobiledoc content format
@kevinansfield
Copy link
Member Author

Closing as this is now located on the Ghost-Admin repo.

@kevinansfield
Copy link
Member Author

kevinansfield commented Jun 6, 2016

Oops, I was a little over-zealous with the PR closing earlier. Re-opening as this contains the server-side component of the new editor spike, the client-side part of this lives here.

@kevinansfield kevinansfield reopened this Jun 6, 2016
@kevinansfield
Copy link
Member Author

Closing as this has served it's purpose and we're now working on a new mobiledoc implementation.

geekhuyang pushed a commit to geekhuyang/Ghost that referenced this pull request Nov 20, 2016
refs TryGhost#6301, TryGhost#6255

- new, extra-long, column for storing mobiledoc content format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants