-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider uglify-es by default #34
Comments
PR welcome |
@TrySound, since uglify-es represents the UglifyJS version 3, and its API is not backward compatible with version 2, it would be interesting to test it before merge (apparently the tests passed). |
This project uses uglify3 |
Nice, thanks! In this case, is that PR apt to be approved? Or does it no longer make sense? I'm asking this because of the warning about ES2015. Is the following approach still necessary? import { rollup } from 'rollup';
import uglify from 'rollup-plugin-uglify';
import { minify } from 'uglify-es';
rollup({
entry: 'main.js',
plugins: [
uglify({}, minify)
]
}); |
Seems like ES6 is still an issue with this plugin. The trick mentioned above is not longer possible: uglify({}, minify) // This won't work The uglify function takes only one I tried @babel/preset-env with
But it's not working so far |
Yes, use this one https://github.com/TrySound/rollup-plugin-terser. |
Thanks for the quick reply, works really well now 👍 |
Webpack uglify plugin just started using uglify-es by default.
webpack-contrib/uglifyjs-webpack-plugin#63
The text was updated successfully, but these errors were encountered: