pointToPolygonDistance with hole return unsigned values

[ata-electronics]

Hello,
The pointToPolygonDistance function return positive value for a point in polygon with an hole:

How to reproduce :
Use this file in https://turf-sandbox.netlify.app/
turfSandbox_scipt_pointToPolygonDistance.txt

Fix:
I think that the issue is on line 72 of file https://github.com/Turfjs/turf/blob/master/packages/turf-point-to-polygon-distance/index.ts
return Math.min(smallestInteriorDistance, Math.abs(exteriorDistance));
should be replaced by
return Math.max(smallestInteriorDistance*-1, exteriorDistance);

[smallsaucepan]

Well done tracking that down @ata-electronics.

Would you mind explaining what was happening and how the different logic fixes the problem?

And also, do you have any idea why the existing test in multi-polygon.geojson didn't catch this issue?

[LHBruneton-C2C]

Hello,

I've looked up this issue. I agree with @ata-electronics suggestion, and I can explain why.

You can have a look at this PR #2845

And the existing multi-polygon.geojson didn't catch this issue because it only happens with polygons. Multi-polygons are correctly re-signed on line 56 with the call to booleanPointInPolygon.