-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against node 15 #1138
Merged
Merged
Test against node 15 #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
=======================================
Coverage 79.32% 79.32%
=======================================
Files 7 7
Lines 711 711
Branches 158 158
=======================================
Hits 564 564
Misses 90 90
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3x new test matrix entries for node 15, against typescript 2.7, latest, and next
Fixed one test case, where we used a regexp to match an error stack from node. Internal node changes meant the stack is slightly different, so I updated the regexp to match.
node 15 comes with npm v7, but npm v7 has some buggy(?) changes to peerDependencies handling. I don't want to deal with this, so I avoid it by downgrading to npm v6.