-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR/#169] 성지순례 카테고리 조회 리팩토링 및 서비스 테스트 추가 #175
Merged
Merged
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a57d370
[REFACTOR/#169] 자동 정렬 추가
ppparkta 510a0ad
[REFACTOR/#169] 안 쓰는 Import 제거 및 자동정렬
ppparkta ae6ff51
[TEST/#169] 성지순례 애니별 카테고리 조회 성공 테스트 추가
ppparkta ee88980
[TEST/#169] 성지순례 애니별 카테고리 조회 성공 테스트 추가
ppparkta 52d9f4c
[TEST/#169] 로그인 포함 성지순례 애니별 카테고리 조회 성공 테스트 추가
ppparkta 0eb9f8c
[TEST/#169] 비로그인 성지순례 애니별 조회 비교 추가
ppparkta 6e643b8
[TEST/#169] 테스트용 인메모리 DB 설정
ppparkta 4813a57
[REFACTOR/#169] develop 브랜치 병합
ppparkta 13592d2
[REFACTOR/#169] pilgrimageQueryService 테스트코드 경로 수정
ppparkta ae56855
[REFACTOR/#169] pilgrimageCategoryQueryService 분리
ppparkta eb9f5a7
[REFACTOR/#169] 개행 제거
ppparkta 46631d2
Merge branch 'develop' into refactor/#169
ppparkta 8cf2155
[REFACTOR/#169] 성지순례 카테고리 조회 서비스 리팩토링
ppparkta da93031
[TEST/#169] 성지순례 지역 별 조회 테스트 코드 추가
ppparkta b1710aa
[REFACTOR/#169] 성지순례 지역 추가 로직 수정
ppparkta 517836c
[TEST/#169] 성지순례 지역 상세 조회 서비스 테스트 추가
ppparkta 01625f1
[CHORE/#169] 사용하지 않는 print문 제거
ppparkta ab1418e
[REFACTOR/#169] lombok implementation -> testComfileOnly 수정
ppparkta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
src/main/java/com/favoriteplace/app/pilgrimage/service/PilgrimageCategoryQueryService.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,138 @@ | ||
package com.favoriteplace.app.pilgrimage.service; | ||
|
||
import com.favoriteplace.app.member.domain.Member; | ||
import com.favoriteplace.app.member.repository.MemberRepository; | ||
import com.favoriteplace.app.pilgrimage.controller.dto.PilgrimageResponseDto; | ||
import com.favoriteplace.app.pilgrimage.controller.dto.PilgrimageResponseDto.PilgrimageAddressDetailDto; | ||
import com.favoriteplace.app.pilgrimage.controller.dto.PilgrimageResponseDto.PilgrimageCategoryRegionDto; | ||
import com.favoriteplace.app.pilgrimage.converter.PilgrimageConverter; | ||
import com.favoriteplace.app.pilgrimage.domain.Pilgrimage; | ||
import com.favoriteplace.app.pilgrimage.repository.PilgrimageRepository; | ||
import com.favoriteplace.app.pilgrimage.repository.VisitedPilgrimageRepository; | ||
import com.favoriteplace.app.rally.controller.dto.RallyResponseDto.PilgrimageCategoryAnimeDto; | ||
import com.favoriteplace.app.rally.converter.RallyConverter; | ||
import com.favoriteplace.app.rally.domain.Address; | ||
import com.favoriteplace.app.rally.domain.Rally; | ||
import com.favoriteplace.app.rally.repository.AddressRepository; | ||
import com.favoriteplace.app.rally.repository.RallyRepository; | ||
import com.favoriteplace.global.auth.resolver.UserEmail; | ||
import com.favoriteplace.global.exception.ErrorCode; | ||
import com.favoriteplace.global.exception.RestApiException; | ||
|
||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Set; | ||
import java.util.stream.Collectors; | ||
|
||
import lombok.RequiredArgsConstructor; | ||
|
||
import org.springframework.stereotype.Service; | ||
|
||
@Service | ||
@RequiredArgsConstructor | ||
public class PilgrimageCategoryQueryService { | ||
private final MemberRepository memberRepository; | ||
private final RallyRepository rallyRepository; | ||
private final VisitedPilgrimageRepository visitedPilgrimageRepository; | ||
private final AddressRepository addressRepository; | ||
private final PilgrimageRepository pilgrimageRepository; | ||
|
||
/*** | ||
* 성지순례 애니 별 카테고리 | ||
* @param email 사용자 이메일 | ||
* @return | ||
*/ | ||
public List<PilgrimageCategoryAnimeDto> getCategoryAnime(@UserEmail String email) { | ||
List<Rally> rallyList = rallyRepository.findAllOrderByCreatedAt(); | ||
|
||
if (email == null || email.isEmpty()) { | ||
return getPilgrimageAnimeCategoryWithoutMember(rallyList); | ||
} | ||
|
||
Member member = getMemberByEmail(email); | ||
return getPilgrimageAnimeCategoryWithMember(rallyList, member); | ||
} | ||
|
||
/*** | ||
* 성지순례 지역 별 카테고리 | ||
* @return state 별로 그룹화 한 지역 정보 | ||
*/ | ||
public List<PilgrimageResponseDto.PilgrimageCategoryRegionDto> getCategoryRegion() { | ||
List<Address> address = addressRepository.findAll(); | ||
|
||
Set<String> addressKeyList = getStateAll(address); | ||
Map<String, List<Address>> addressGroupByState = getDistrictGroupByState(address); | ||
|
||
return getPilgrimageCategoryRegionDtos(addressKeyList, addressGroupByState); | ||
} | ||
|
||
/*** | ||
* 성지순례 지역 상세 카테고리 | ||
* @param regionId | ||
* @return district 별 성지순례 리스트 | ||
*/ | ||
public List<PilgrimageResponseDto.PilgrimageCategoryRegionDetailDto> getCategoryRegionDetail(Long regionId) { | ||
Address address = getAddressByRegion(regionId); | ||
List<Pilgrimage> pilgrimages = pilgrimageRepository.findByAddress(address); | ||
|
||
return pilgrimages.stream() | ||
.map(pilgrimage -> { | ||
Rally rally = rallyRepository.findByPilgrimage(pilgrimage); | ||
return PilgrimageConverter.toPilgrimageCategoryRegionDetailDto(rally.getName(), pilgrimage); | ||
}) | ||
.toList(); | ||
} | ||
|
||
private Member getMemberByEmail(String email) { | ||
return memberRepository.findByEmail(email) | ||
.orElseThrow(() -> new RestApiException(ErrorCode.USER_NOT_FOUND)); | ||
} | ||
|
||
private List<PilgrimageCategoryAnimeDto> getPilgrimageAnimeCategoryWithMember(List<Rally> rallyList, | ||
Member member) { | ||
return rallyList.stream().map(rally -> { | ||
Long visitedPilgrimages = visitedPilgrimageRepository.findByDistinctCount(member.getId(), rally.getId()); | ||
return RallyConverter.toPilgrimageCategoryAnimeDto(rally, visitedPilgrimages); | ||
}).toList(); | ||
} | ||
|
||
private List<PilgrimageCategoryAnimeDto> getPilgrimageAnimeCategoryWithoutMember(List<Rally> rallyList) { | ||
return rallyList.stream() | ||
.map(rally -> RallyConverter.toPilgrimageCategoryAnimeDto(rally, 0L)) | ||
.toList(); | ||
} | ||
|
||
private Address getAddressByRegion(Long regionId) { | ||
return addressRepository.findById(regionId).orElseThrow(() -> | ||
new RestApiException(ErrorCode.ADDRESS_NOT_FOUND)); | ||
} | ||
|
||
private Map<String, List<Address>> getDistrictGroupByState(List<Address> address) { | ||
return address.stream() | ||
.collect(Collectors.groupingBy(Address::getState)); | ||
} | ||
|
||
private Set<String> getStateAll(List<Address> address) { | ||
return address.stream() | ||
.map(Address::getState) | ||
.collect(Collectors.toSet()); | ||
} | ||
|
||
private List<PilgrimageCategoryRegionDto> getPilgrimageCategoryRegionDtos(Set<String> addressKeyList, | ||
Map<String, List<Address>> addressGroupByState) { | ||
return addressKeyList.stream().map( | ||
stateKey -> { | ||
List<Address> addressList = addressGroupByState.get(stateKey); | ||
List<PilgrimageAddressDetailDto> addressDetailDtos = getPilgrimageAddressDetailDtos( | ||
addressList); | ||
return PilgrimageConverter.toPilgrimageCategoryRegionDto(stateKey, addressDetailDtos); | ||
} | ||
).toList(); | ||
} | ||
|
||
private List<PilgrimageAddressDetailDto> getPilgrimageAddressDetailDtos(List<Address> addressList) { | ||
return addressList.stream() | ||
.map(PilgrimageConverter::toPilgrimageAddressDetailDto) | ||
.toList(); | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거
implementation
으로 바꾸신 이유가 있나요?? (단순 궁금증)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트코드 작성할 때 롬복이 필요해서 수정했어요!
찾아보니까 compileOnly + testCompileOnly 쓰는것보다 implementation만 쓰는게 더 무겁다고 하네요...
gradle 파일 길어지면 관리가 까다로워질까봐 수정한건데 원래대로 되돌리는게 더 좋을거 같아요!
+) 수정했습니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오..새로운 사실 덕분에 알아가요 좋습니다!!