Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the time increase component of the countdown (collaboration with Team 8) #83

Open
2 tasks done
riotanabe opened this issue Sep 12, 2022 · 4 comments
Open
2 tasks done
Assignees
Labels
task New task as part of implementing a feature Team 4 Sprint 4: Improve Countdown Clock and Bug Fix Team 8

Comments

@riotanabe
Copy link
Contributor

riotanabe commented Sep 12, 2022

Description

Task: Implement the time increase component of the countdown
Feature: Countdown Clock(#3)

Picking up a time buffer item should increase the remaining time for the game by a specific increment. If a player picks up a time buffer item and decides to use it, the time remaining should be increased.

Dependencies

Completion Deadline: Sep. 12

Documentation

Member

@riotanabe riotanabe added task New task as part of implementing a feature Team 4 Sprint 4: Improve Countdown Clock and Bug Fix Team 8 labels Sep 12, 2022
@riotanabe
Copy link
Contributor Author

riotanabe commented Sep 12, 2022

@Connor-Ryan-1998 Hi, I am thinking --> import the ConsumableItemFactory class into countdownDisplay, call the getConsumableTimeIncrease method to get the time increase int, and increase the timeRemaining by that increment in countdownDisplay.

Or --> import countdownDisplay into ConsumableItemFactory, and call timeIncrease method of the countdownDisplay class in the ConsumableItemFactory on trigger of the player picking up the item.

Currently, is there an event trigger implemented for the player picking up an item; how do we know that the player has picked up an item?

Thanks.
Rio

@Connor-Ryan-1998
Copy link
Contributor

@riotanabe Have a look over the commit I mentioned previously on your ticket. We don't want to trigger the time increase based on pick up. We add it to the inventory to be consumed when the player wants. This currently directly hits the entity for the count down and attempts to add 30 seconds to the timer

@riotanabe
Copy link
Contributor Author

@Connor-Ryan-1998 sorry, what do you mean "directly hits the entity for the count down"?
Currently, the increaseTime method is not called anywhere so time is not added to the timer. Sorry if I am misunderstanding...

@Connor-Ryan-1998
Copy link
Contributor

@riotanabe I have commented on my commit I have refered to and tagged you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task New task as part of implementing a feature Team 4 Sprint 4: Improve Countdown Clock and Bug Fix Team 8
Projects
None yet
Development

No branches or pull requests

2 participants