Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Ceres PCK #4001

Closed
jessemapel opened this issue Sep 4, 2020 · 15 comments
Closed

Update the Ceres PCK #4001

jessemapel opened this issue Sep 4, 2020 · 15 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jessemapel
Copy link
Contributor

Description

This is coming from a lot of discussion on an astrodiscuss post.

While making the HAMO Dawn mosaic, the team produced an updated PCK. We should switch over to using this in the data area. It can be found here: https://sbnarchive.psi.edu/pds3/dawn/fc/DWNCHSPG_2/GEOMETRY/

Example

Running spiceinit on a DAWN FC image of Ceres pulls dawn_ceres_v05.tpc as its PCK right now. It should instead select dawn_ceres_SPG20160107.tpc as its PCK.

@jlaura jlaura added the enhancement New feature or request label Sep 8, 2020
@jlaura
Copy link
Collaborator

jlaura commented Sep 8, 2020

Would making this change be breaking in any way for pipeline users? Or can we make this swap in the next few weeks?

@jessemapel
Copy link
Contributor Author

We don't support an official Dawn pipeline. It should be safe to make this change. Another change that we do do is make this the "smithed" pck and that would maintain backwards compatibility. That is what we did with the Europa PCK.

@jessemapel jessemapel added this to the 4.3.1 milestone Dec 14, 2020
@jessemapel
Copy link
Contributor Author

Even though this is a data area change, I'm labeling this for 4.3.1 because we do push out kernel updates in between releases so this can go out whenever.

@acpaquette acpaquette modified the milestones: 4.3.1, 5.0.1 Apr 10, 2021
@kaitlyndlee kaitlyndlee self-assigned this Apr 19, 2021
@kaitlyndlee
Copy link
Contributor

@jessemapel Looking at the astrodiscuss post, it looks like updating the kernel without adding it as a smithed kernel would be the best solution since it aligns with new spice data. Do you agree?

@jessemapel
Copy link
Contributor Author

I agree, because we default to the corresponding DEM, we should use this as the default PCK for Dawn observations of Ceres.

@kaitlyndlee
Copy link
Contributor

@jessemapel Was there an image you tested this with? I found a few images with CERES as their target, but when I run spiceinit, it gives me an error saying there is no pointing information for that time. I've checked the start times of the images and they fall into one of the ranges defined by the ck kernels db file. I am not sure why I am getting this error.

@jessemapel
Copy link
Contributor Author

I don't have a test image, you'll need to find one.

@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Oct 19, 2021
@jessemapel
Copy link
Contributor Author

This is still something we need to do to improve the usability of Ceres datasets.

@github-actions github-actions bot removed the inactive Issue that has been inactive for at least 6 months label Oct 21, 2021
@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Apr 20, 2022
@jessemapel
Copy link
Contributor Author

Still worth doing

@github-actions github-actions bot removed the inactive Issue that has been inactive for at least 6 months label Apr 21, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Dec 3, 2022
@jlaura
Copy link
Collaborator

jlaura commented Dec 5, 2022

@AustinSanders This looks like it is low cost, high value. I suspect it has been lost in the shuffle though. Does it make sense to get this tracked somewhere? Or should we close with a 'will not fix' (since it is 2 years old and hasn't happened)?

@github-actions github-actions bot removed the inactive Issue that has been inactive for at least 6 months label Dec 5, 2022
@AustinSanders
Copy link
Contributor

I can make a Q2 support board that we can use to track issues for next support sprint. It can do double duty as a way to organize continuous support.

@tclark96 tclark96 mentioned this issue Feb 24, 2023
12 tasks
@tclark96 tclark96 moved this to In Progress in FY23 Q2 Support Feb 24, 2023
@tclark96
Copy link
Contributor

tclark96 commented Mar 3, 2023

@jessemapel the downloadIsisData script has been updated to include dawn_ceres_SPG20160107.tpc as well as an updated kernel.db to properly select it.

@tclark96 tclark96 closed this as completed Mar 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in FY23 Q2 Support Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants