Update shadow documentation to mention when SPICE kernels are needed #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scsides
suggested changes
Mar 4, 2021
isis/src/base/apps/shadow/shadow.xml
Outdated
| @@ -20,7 +20,8 @@ | |||
|
|
|||
| <strong>User-Requirements</strong><br/> | |||
| The user must supply an elevation model (DEM) and either an observation time or a cube | |||
| with raw camera geometry (see 'spiceinit').<br/><br/> | |||
| with raw camera geometry (see 'spiceinit'). If providing an observation time, the SPICE kernels | |||
| associated with the image target must have been downloaded and be available on the user's machine.<br/><br/> | |||
There was a problem hiding this comment.
Since you just saw the code, it would be nice to specify which kernels if it can be boiled down. I don't mean file names, more like file types, and might want to use $ISISDATA in the description
scsides
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shadowalready supported getting sun position from a spiceinited cube, so this is just a documentation update to explain in what circumstances local kernels are required.Related Issue
#4303
Motivation and Context
See #4303 .
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: