fix: Update Matomo initialization #1114
Conversation
| @@ -416,7 +416,7 @@ describe('Analytics context', () => { | |||
| 'setDocumentTitle', | |||
| 'Test Doc Title', | |||
| ]) | |||
| expect(windowWithAnalytics._paq[1]).toEqual(['setDoNotTrack', true]) | |||
| expect(windowWithAnalytics._paq[1]).toEqual(['setDoNotTrack', false]) | |||
There was a problem hiding this comment.
We talked about this during one of our meetings and decided it should be a launch darkly flag. Suggestion is to name it MatomoClientSideDoNotTrack and have it return true or false to be set here.
There was a problem hiding this comment.
After initial investigation this wasn't working, not sure that LD is initialized early enough for it two work. So we decided to just leave it as is for now so we can confirm it allows us to track rank and location properly.
jcbcapps
changed the title
| @@ -416,7 +416,7 @@ describe('Analytics context', () => { | |||
| 'setDocumentTitle', | |||
| 'Test Doc Title', | |||
| ]) | |||
| expect(windowWithAnalytics._paq[1]).toEqual(['setDoNotTrack', true]) | |||
| expect(windowWithAnalytics._paq[1]).toEqual(['setDoNotTrack', false]) | |||
There was a problem hiding this comment.
After initial investigation this wasn't working, not sure that LD is initialized early enough for it two work. So we decided to just leave it as is for now so we can confirm it allows us to track rank and location properly.
SC-2582
Proposed changes
This PR
setDoNotTrackoption in Matomo's initialization tofalsetrackRankandtrackBaseLocationinto auseEffectReviewer notes
Setup
Start the system
yarn services:up yarn dev cd ../ussf-portal-cms yarn devLogin to the portal http://localhost:3000
Start storybook
Login to storybook http://localhost:6006, though the command above should open it for you
Code review steps
As the original developer, I have
As a reviewer, I have
Check out our How to review a pull request document.
Screenshots