fix: Open document in browser #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #2436: Double check why documents are downloading, rather than opening. |
abbyoung
force-pushed
the
sc-2436-open-doc-in-browser
branch
from
9c64eec to
1540ee6
Compare
abbyoung
changed the title
abbyoung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-2436
Proposed changes
endsWithtoincludeswhen checking an asset url for thepdfextensionPDFs will now open in-browser. Other document formats will continue to download to a user's machine.
Reviewer notes
In addition to the small code change, we need to update the CORS settings on the s3 bucket. This change has been made on dev, so the feature should now work as expected on dev.ussforbit.us. @jbecker01 Let me know when you're ready to test and I can double check that the branch is available on dev!
When we're ready to deploy, we'll also need @minhlai's assistance to make the changes on staging and prod.
Setup
Start the system
yarn services:up yarn dev cd ../ussf-portal-cms yarn devLogin to the portal http://localhost:3000
Start storybook
Login to storybook http://localhost:6006, though the command above should open it for you
Code review steps
As the original developer, I have
As a reviewer, I have
Check out our How to review a pull request document.
Screenshots