feat: Add LoadingWidget to Guardian Directory page #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #2984: Add LoadingWidget to the Guardian Directory. |
jcbcapps
pushed a commit
that referenced
this pull request
Jan 4, 2024
## [4.29.0](4.28.0...4.29.0) (2024-01-03) ### Features * add lastLoginAt to user ([#1185](#1185)) ([c54ad4a](c54ad4a)) * Add LoadingWidget to Guardian Directory page ([#1188](#1188)) ([11611bf](11611bf)) * Add search to guardian directory ([#1183](#1183)) ([265731b](265731b)) ### Bug Fixes * **design:** Footer Navigation + Layout enhancements ([#1180](#1180)) ([6e6a1bd](6e6a1bd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-2984
Proposed changes
Add the LoadingWidget to the Guardian Directory
Reviewer notes
Navigate to
http://localhost:3000/guardian-directoryWhen running this locally, you probably won't see the loading state because of how few test fields there are. You can do one of two things:
src/pages/guardian-directory.tsxand change!directory.lengthon line 86 totrue. Save and reload the app to see the loading state.Setup
Start the system
yarn services:up yarn dev cd ../ussf-portal-cms yarn devLogin to the portal http://localhost:3000
Start storybook
Login to storybook http://localhost:6006, though the command above should open it for you
Code review steps
As the original developer, I have
As a reviewer, I have
Check out our How to review a pull request document.
Screenshots