feat: Create new portal user from JWT request if one doesn't exist #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #3202: Third-Party API: Create auth'd user in portal if none exists. |
abbyoung
commented
Feb 8, 2024
src/pages/api/thirdparty/graphql.tsx
Outdated
| } | ||
| // Q: Should we include last login? They are technically | ||
| // not logging in to the portal. Do we want to use it to track | ||
| // API access as well? |
There was a problem hiding this comment.
Question here for @gidjin @jcbcapps @jbecker01 -- do we want to track lastLogIn field for a user created via third-party API?
There was a problem hiding this comment.
I can go either way on that. I can see both sides. Maybe we leave it off for now?
gidjin
reviewed
Feb 15, 2024
src/pages/api/thirdparty/graphql.tsx
Outdated
| } | ||
| // Q: Should we include last login? They are technically | ||
| // not logging in to the portal. Do we want to use it to track | ||
| // API access as well? |
There was a problem hiding this comment.
I can go either way on that. I can see both sides. Maybe we leave it off for now?
gidjin
approved these changes
Feb 15, 2024
gidjin
approved these changes
Feb 16, 2024
gidjin
pushed a commit
that referenced
this pull request
Feb 22, 2024
## [4.31.0](4.30.1...4.31.0) (2024-02-22) ### Features * Add additional content to third-party API ([#1206](#1206)) ([053cd1d](053cd1d)) * Add Site Header ([#1210](#1210)) ([4f34bc4](4f34bc4)) * Create new portal user from JWT request if one doesn't exist ([#1209](#1209)) ([7e0102c](7e0102c)) * Support additional file types for opening docs in browser ([#1214](#1214)) ([0c67389](0c67389)) ### Bug Fixes * a11y: Guardian Directory field labeling ([#1205](#1205)) ([db3df68](db3df68)) * a11y: edit display name component syntax ([#1204](#1204)) ([c6408cf](c6408cf)) * a11y: move skip link anchor entry point to unique page content in default layout ([#1212](#1212)) ([c2e8e8e](c2e8e8e)) * adds page title to Guardian Directory page ([#1211](#1211)) ([8f0b0cb](8f0b0cb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-3202
Proposed changes
If a valid JWT is passed to the third-party API and the user doesn't exist in the portal db (meaning they have never logged in), we now create a new portal user in mongodb.
Because we don't get their full name in the token. I'm setting the displayName to their CN. If/when they log in to the portal it can easily be updated.
Reviewer notes
e2e branch: sc-3202-create-new-user-third-party-api
Setup
Start the system
yarn services:up yarn dev cd ../ussf-portal-cms yarn devLogin to the portal http://localhost:3000
Start storybook
Login to storybook http://localhost:6006, though the command above should open it for you
Code review steps
As the original developer, I have
As a reviewer, I have
Check out our How to review a pull request document.
Screenshots