fix: a11y: move skip link anchor entry point to unique page content in default layout #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge content instead of the main element
|
This pull request has been linked to Shortcut Story #3212: ensure bypass function goes to page content, and not just inside the main element. |
|
oop i messed up a test, gotta update it to not look for the id on the main element |
gidjin
previously approved these changes
Feb 15, 2024
gidjin
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Looks like id isn't getting rendered on the Grid component. Looks like it's not being passed down correctly. From what I can tell it's the same as not having the id at all. Is this working for you? We might need to fix the Grid component to properly pass id down.
AnnaGingle
approved these changes
Feb 20, 2024
gidjin
approved these changes
Feb 22, 2024
gidjin
pushed a commit
that referenced
this pull request
Feb 22, 2024
## [4.31.0](4.30.1...4.31.0) (2024-02-22) ### Features * Add additional content to third-party API ([#1206](#1206)) ([053cd1d](053cd1d)) * Add Site Header ([#1210](#1210)) ([4f34bc4](4f34bc4)) * Create new portal user from JWT request if one doesn't exist ([#1209](#1209)) ([7e0102c](7e0102c)) * Support additional file types for opening docs in browser ([#1214](#1214)) ([0c67389](0c67389)) ### Bug Fixes * a11y: Guardian Directory field labeling ([#1205](#1205)) ([db3df68](db3df68)) * a11y: edit display name component syntax ([#1204](#1204)) ([c6408cf](c6408cf)) * a11y: move skip link anchor entry point to unique page content in default layout ([#1212](#1212)) ([c2e8e8e](c2e8e8e)) * adds page title to Guardian Directory page ([#1211](#1211)) ([8f0b0cb](8f0b0cb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-3212
Proposed changes
this branch edits the
DefaultLayout.tsxfile which is out base for our core functionality pagesMy Space,Sites & Applications,Guardian Directorythat have the left side nave and repeatedPageHeadercomponent to move the id anchor link for theSkip to main contentlink to direct to.This ensures the user can skip right to the unique page content instead of getting directed to the search, side nav, etc.
This ensures compliance for WCAG 2.0 2.4.1 Bypass success criteria Trusted Tester ID 9A
Reviewer notes
this PR does not make changes to the other page layouts, which appear to be compliant. I am unsure if we should skip the
Page Headercomponent on thePageLayout.tsxlayout.Setup
Start the system
yarn services:up yarn dev cd ../ussf-portal-cms yarn devLogin to the portal http://localhost:3000
Press
Tabto expose theSkip to main contentlink and ensure it skips the repeated content we have on other pages, and that it goes directly to our unique page content in all system page layouts.Code review steps
As the original developer, I have
As a reviewer, I have
Check out our How to review a pull request document.
Screenshots
skip.link.mp4