Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sorting Sites & Applications #231

Merged
merged 37 commits into from
Sep 21, 2021
Merged

feat: Sorting Sites & Applications #231

merged 37 commits into from
Sep 21, 2021

Conversation

suzubara
Copy link
Contributor

@suzubara suzubara commented Sep 13, 2021

Description

This PR adds sorting to the Sites & Applications page, and also makes some adjustments to existing components & types in order to have stronger typing for API data displayed in the UI.

Fixes #212

Review Notes

  • Navigate to the Sites & Applications page
  • By default, you should see bookmarks grouped by Collection and the "Sort by type" button should be selected
  • Verify you can click "Sort alphabetically" to swap to a list view, and all bookmarks are listed alphabetically by name

Screenshots

sorting

Base automatically changed from 211-bookmark-list-component to main September 13, 2021 22:46
@suzubara suzubara changed the title WIP sites apps sorting feat: Sorting Sites & Applications Sep 14, 2021
@github-actions
Copy link
Contributor

🎉 View the deployed prototype - https://212-sites-apps-sorting--ussf-portal-client.netlify.app

@jbecker01
Copy link
Contributor

@suzubara can we open the links in a new tab/window.

@suzubara
Copy link
Contributor Author

@suzubara can we open the links in a new tab/window.

Whoops, yes sorry! That should be done now

@github-actions
Copy link
Contributor

🎉 View the deployed prototype - https://212-sites-apps-sorting--ussf-portal-client.netlify.app

Copy link
Contributor

@jbecker01 jbecker01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@suzubara suzubara merged commit 4c30c7a into main Sep 21, 2021
@suzubara suzubara deleted the 212-sites-apps-sorting branch September 21, 2021 15:34
@suzubara suzubara mentioned this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort links alphabetically on S&A page
3 participants