Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom link to collection #249

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Conversation

suzubara
Copy link
Contributor

@suzubara suzubara commented Oct 1, 2021

Description

This PR adds the "Add link" flow to the Custom Collection component, allowing users to add arbitrary links to existing collections.

In the interest of keeping PRs small, this does not include the modal that asks a user to enter a custom label for their link. That feature is added in #250

I'm considering this branch to be feature complete since a user is still able to add a link. The display text will just default to the URL.

Fixes #233

Review Notes

  • Verify you can click "Add link" on an existing collection in My Space to add a new URL to the collection.
  • The text input should validate that you have entered a complete & valid URL. Entering other text or no text at all should prevent you from submitting the link.
  • Since the link is only added in the local cache, refreshing the page will reset any changes you've made.

addLink

@suzubara suzubara changed the title [WIP] feat: Add link to collection feat: Add link to collection Oct 4, 2021
@suzubara suzubara changed the title feat: Add link to collection feat: Add custom link to collection Oct 4, 2021
@suzubara suzubara marked this pull request as ready for review October 4, 2021 21:20
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

🎉 View the deployed prototype - https://233-add-link-to-collection--ussf-portal-client.netlify.app

@@ -1,4 +1,4 @@
.usa-button {
.button-pill {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we need to create new _buttons and _global files outside of the mvp directory -- were we just using mvp for the rebuild? or keep it for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were just used for the mvp, until we start changing the global level branding/theming of standard USWDS buttons I think we can hold off

Copy link
Contributor

@abbyoung abbyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! 🎸

Copy link
Contributor

@jbecker01 jbecker01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suzubara suzubara merged commit 95bc376 into main Oct 5, 2021
@suzubara suzubara deleted the 233-add-link-to-collection branch October 5, 2021 17:19
@suzubara suzubara mentioned this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants