-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add custom link to collection #249
Conversation
🎉 View the deployed prototype - https://233-add-link-to-collection--ussf-portal-client.netlify.app |
@@ -1,4 +1,4 @@ | |||
.usa-button { | |||
.button-pill { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we need to create new _buttons and _global files outside of the mvp directory -- were we just using mvp for the rebuild? or keep it for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were just used for the mvp, until we start changing the global level branding/theming of standard USWDS buttons I think we can hold off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent! 🎸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
This PR adds the "Add link" flow to the Custom Collection component, allowing users to add arbitrary links to existing collections.
In the interest of keeping PRs small, this does not include the modal that asks a user to enter a custom label for their link. That feature is added in #250
I'm considering this branch to be feature complete since a user is still able to add a link. The display text will just default to the URL.
Fixes #233
Review Notes