feat: Sites & Applications UX fixes #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 View the deployed prototype - https://286-sites-apps-ux-fixes--ussf-portal-client.netlify.app |
suzubara
force-pushed
the
286-sites-apps-ux-fixes
branch
from
b04d63d to
ddf1a96
Compare
* added hover overs * Added hovers to main nav * Added new styles to filter buttons on S&A * Added font weight
|
🎉 View your component in Storybook - https://286-sites-apps-ux-fixes--ussf-storybook.netlify.app |
|
🎉 View the deployed prototype - https://286-sites-apps-ux-fixes--ussf-portal-client.netlify.app |
suzubara
changed the title
|
🎉 View the deployed prototype - https://286-sites-apps-ux-fixes--ussf-portal-client.netlify.app |
jbecker01
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
From what I could check, it looks good!
- Adjust MySpace columns to 3, maybe adjust margins/padding
- Change color on search dropdown text to white
- Change padding on collections boxes (24px for top/bottom and 16pc for L/R)
- Even out padding within myspace container (24px on all sides)
- Remove side nav links that are unused (My profile, Subordinate profiles, etc...)
- Change all footer text to white
- Add hover states to buttons
- Remove hover state for search dropdown
- "Add section" box height should be equal to a collection card with 5 links inside it
- "Search" text is not using trebuchet
- In "alphabetical" view, description columns will need to be moved to the left to make room for more content (Note: this might actually be resolved on it's own once content is added)
- Add hover states to main nav
- Update button styles on alphabetical/type sorts
- ReactUSWDS ComboBox scroll bug ([fix] ComboBox scroll behavior [fix] ComboBox scroll behavior trussworks/react-uswds#1693)
malworks
suggested changes
Nov 1, 2021
malworks
approved these changes
Nov 1, 2021
abbyoung
approved these changes
Nov 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some small UX/design fixes as described in #286 (everything listed in the COMPLETED section). It does not cover the items contained in separate issues.
Fixes #286
Review Notes
Review the deployed app & Storybook against the list of UX fixes above and verify that they are in fact completed.