fix: Unable to close out of flyout menu #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 View the deployed prototype - https://282-fix-mobile-nav--ussf-portal-client.netlify.app |
|
The issue mentions being able to close the menu with a click outside the menu. Currently, it stays open. Could we add the |
suzubara
force-pushed
the
282-fix-mobile-nav
branch
from
0187d57 to
86cb8b0
Compare
Okaaaaaay done! |
|
🎉 View the deployed prototype - https://282-fix-mobile-nav--ussf-portal-client.netlify.app |
abbyoung
approved these changes
Nov 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a small adjustment to the header/nav overlay markup so those elements are not flex children (direct descendants of an element with
display: flex), which was interfering with their z-index when the overlay is open.Fixes #282
Review Notes
To test, view the site at a mobile/tablet screen size and open the header navigation (the Menu button). Verify you are able to interact with the links, and close the menu by clicking the "X" icon.