fix: Init analytics context from API data #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzubara
commented
Feb 2, 2022
| @@ -10,5 +10,7 @@ export default function handler(req: NextApiRequest, res: NextApiResponse) { | |||
| version: __VERSION__, | |||
| buildId: __BUILD_ID__, | |||
| nodeEnv: __NODE_ENV__, | |||
| analyticsUrl: process.env.MATOMO_URL, | |||
There was a problem hiding this comment.
@abbyoung this info seemed appropriate to add to this existing endpoint, but let me know if you feel otherwise!!
abbyoung
approved these changes
Feb 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how the AnalyticsContext is initialized. Instead of using NextJS runtime variables (which produced inconsistent & confusing results), the analytics code makes a request to
/api/sysinfoto query the Matomo URL & site ID in the browser. This lets us set those environment variables at runtime without having to worry about build variables. We may revisit this in the future if we start building images per-environment, but for now it should make the analytics init more consistent.Fixes #501
Review Notes
ANALYTICS: No Matomo URL provided.