-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove beta gate, deprecate MVP site #565
Conversation
…sc-145/remove-beta-gate
This pull request has been linked to Shortcut Story #145: Remove beta UI elements. |
source: '/training-and-education/force-multiplier-program', | ||
destination: '/404', | ||
permanent: false, | ||
}, | ||
] | ||
}, | ||
async rewrites() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we eventually reorg the file structure to get rid of the beta
dir and these rewrites?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! in sc-146
As code reviewer(s), I have
Tested across Chrome, FF, and Edge on Windows. Also tested on Mac Safar and Chrome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
SC-145
Proposed changes
This PR removes the opt-in beta UX from the portal, and deprecates the MVP routes by redirecting them to the 404 page (deprecation will be completed in sc-146 when the MVP code is removed altogether). The beta banner is also removed from the layout, so users can no longer join or leave beta.
This change also revealed an existing bug with the canonical link tag, I created a follow up story for that: sc-386
Reviewer notes
Code review steps
As the original developer, I have
As code reviewer(s), I have
As a designer reviewer, I have
Screenshots