feat: Force Multiplier Program page #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzubara
reviewed
Jul 28, 2021
| <LinkTo | ||
| className="usa-button usa-button--big external-link--alt text-white text-no-underline" | ||
| href="http://digitalu.udemy.com"> | ||
| Register |
There was a problem hiding this comment.
I noticed this button doesn't have the same hover state as on the MVP site, not a huge deal but maybe worth just looking into?
There was a problem hiding this comment.
great catch! thank you!
| <Grid | ||
| tablet={{ col: 8 }} | ||
| className="usa-prose bg-gray-cool-3 padding-3"> | ||
| {/* <div className="tablet:grid-col-8 usa-prose bg-gray-cool-3 padding-3"> */} |
There was a problem hiding this comment.
can this line be removed?
suzubara
approved these changes
Jul 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This PR is branched from #58, so I'll merge that PR first and clean up the diff.
Fixes #20
Review Notes
Font Awesome Pro strikes again! Two of the shape icons on the page, the triangle and hexagon, are both inexplicably Pro level icons.
Because these feature prominently, I tried to find a workaround. While we don't have an auth token/registry setup for Pro, the MVP repo does have all the required files to use the Pro icons.
To try and reduce the bulk, I copied over only the essential files and was able to use the icons as
<i>elements.Lmk what you think + if there's another solution.