-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Search results page #663
Conversation
This pull request has been linked to Shortcut Story #388: Search page handler. |
…client into sc-387/search-ui
This pull request has been linked to Shortcut Story #593: Add Label type to CMS schema. |
|
||
const Search = ({ disabled }: { disabled?: boolean }) => { | ||
const disableClass = classnames({ | ||
[styles.disabled]: disabled, | ||
}) | ||
|
||
// TODO - re-add filter dropdown & suggested terms as future work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for leaving this note!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected, looks great, so excited to see this 🎉
SC-388
Proposed changes
This PR implements the Search page, including a handler that queries the CMS Search operation. It does not make the Search page/form discoverable by users - it can only be accessed by navigating directly to
/search
.Dependent on #661 and https://github.com/USSF-ORBIT/ussf-portal-cms/pull/60
Reviewer notes
InternalNews
category will be returned. Draft/Archived and ORBIT Blog articles will not.Setup
yarn dev
/search
. You should be able to enter search terms into the form in the header and view results.Code review steps
As the original developer, I have
As code reviewer(s), I have
As a designer reviewer, I have
As a test user, I have
Screenshots
Search results

Search result (single)

No results

No query (empty search page) -- needs design
