feat: Update URL for News & Announcements and News listing page

[jcbcapps]

SC-769

Proposed changes

• Update the URL for current /news page to be /news-announcements
• For the existing /internal-news page, update the URL to /news

---

Reviewer notes

• Click on the News button in the top right of the header and verify that it takes you to /news-announcements where news from the RSS feed is displayed.
• Manually navigate to /news and verify that published articles from your local CMS are being displayed.

Setup

Make sure to have both the CMS and the portal client running on your local machine. You can do this by

• Running yarn services:up && yarn dev in the CMS repo and
• Running yarn dev in the portal client with this branch checked out

---

Code review steps

As the original developer, I have

• Met the acceptance criteria, or will meet them in subsequent PRs or stories
• Created new stories in Storybook if applicable
  • Checked that all Storybook accessibility checks are passing
• Created/modified automated unit tests in Jest
  • Including jest-axe checks when UI changes
• Created/modified automated E2E tests in Cypress
  • Including cypress-axe checks when UI changes
• Performed a11y testing:
  • Checked responsiveness in mobile, tablet, and desktop
  • Checked keyboard navigability
  • Tested with VoiceOver in Safari
  • Checked VO's rotor menu for landmarks, page heading structure and links
  • Used a browser a11y tool to check for issues (WAVE, axe, ANDI or Accessibility addon tab for Storybook)
• Requested a design review for user-facing changes
• For any new migrations/schema changes:
  • Followed guidelines for zero-downtime deploys

As code reviewer(s), I have

• Pulled this branch locally and tested it
• Reviewed this code and left comments
• Checked that all code is adequately covered by tests
• Made it clear which comments need to be addressed before this work is merged
• Considered marking this as accepted even if there are small changes needed
• Performed a11y testing:
  • Checked responsiveness in mobile, tablet, and desktop
  • Checked keyboard navigability
  • Tested with VoiceOver in Safari
  • Checked VO's rotor menu for landmarks, page heading structure and links
  • Used a browser a11y tool to check for issues (WAVE, axe, ANDI or Accessibility addon tab for Storybook)

As a designer reviewer, I have

• Checked in the design translated visually
• Checked behavior
• Checked different states (empty, one, some, error)
• Checked for landmarks, page heading structure, and links
• Tried to break the intended flow
• Performed a11y testing:
  • Checked responsiveness in mobile, tablet, and desktop
  • Checked keyboard navigability
  • Tested with VoiceOver in Safari
  • Checked VO's rotor menu for landmarks, page heading structure and links
  • Used a browser a11y tool to check for issues (WAVE, axe, ANDI or Accessibility addon tab for Storybook)

As a test user, I have

• Run through the Test Script:
  • On commercial internet in IE11
  • On commercial internet in Firefox
  • On commercial internet in Chrome
  • On commercial internet in Safari
  • On NIPR in IE11
  • On NIPR in Firefox
  • On NIPR in Chrome
  • On NIPR in Safari
  • On a mobile device in Firefox
  • On a mobile device in Chrome
  • On a mobile device in Safari
• Added any anomalous behavior to this PR

[shortcut-integration]

This pull request has been linked to Shortcut Story #769: Update URL for News & Announcements and News listing page.

[abbyoung]

looking good! i do think there's a couple more places we need to change /news -> /news-announcements

• In NewsWidget.tsx, the 'View All' button still points to /news (The test needs to be updated, too.)
• For consistency, we should update BreadcrumbNav.stories.tsx and BreadCrumbNav.test.tsx which also have the old url
• navigation.spec.js also tests the 'News' button and points to /news for the News page
• auth.spec.js tests /news as a route, which technically is correct since that's now for Internal News. Maybe we add /news-announcements too?

Lmk if I'm mistaken about any of these -- news vs news and announcements is starting to make my head spin!

[gidjin]

LGTM, I wanted to note that SC-772 will follow this up with some additional refinements as discussed.