-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Light / Dark mode toggle to the portal #766
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #968: Add Light / Dark mode toggle to the portal. |
gidjin
reviewed
Sep 12, 2022
…portal-client into sc-968/add-theme-toggle merge
gidjin
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I understand how it's supposed to work I can mark this approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-968
Proposed changes
Adds
ThemeToggle
component for toggling light and dark modeReviewer notes
The
ThemeToggle
component is not being displayed anywhere in the portal yet, as we have yet to set up LaunchDarkly to hide it behind a feature flag. To review this, you'll need to view the component in Storybook or add it into the<Header />
component manually. See the instructions below.Setup
Run
yarn storybook
in the portal client, navigate tolocalhost:6006
in your browser, and look at theThemeToggle
componentIf you would like to see the component in the portal client, you'll need to manually add the
ThemeToggle
component into the<Header />
component after line 102. Then make sure to have both the CMS and the portal client running on your local machine. You can do this byyarn services:up && yarn dev
in the CMS repo andyarn dev
in the portal client with this branch checked outCode review steps
As the original developer, I have
As code reviewer(s), I have
As a designer reviewer, I have
As a test user, I have