-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add launch darkly flag for dark mode toggle #787
feat: add launch darkly flag for dark mode toggle #787
Conversation
This pull request has been linked to Shortcut Story #774: Implement Launch Darkly flags for Dark Mode. |
I noticed that the dark mode setting isn't persistent across all the pages of the portal. Is that something that would be covered under #778 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Looks good! |
streamUrl: 'https://clientstream.launchdarkly.us', | ||
eventsUrl: 'https://events.launchdarkly.us', | ||
}, | ||
})(USSFPortalApp as unknown as ComponentType) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i love typescript 😭 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great, very exciting!
…lag-for-dark-mode-toggle
SC-774
Proposed changes
Configure LaunchDarkly Federal edition and setup
ThemeToggle
to use the first feature flag.Reviewer notes
I setup 4 environments (localhost, dev, staging, and production). Localhost is what should be setup for developer boxes. See the readme changes for how to get it working locally.
I didn't add unit tests for the flag code in
ThemeToggle
because I figured we remove that code once the feature is fully released. But if you feel differently I'm happy to add a couple.TODO add the environment variable for dev to the AWS dev environment.
Setup
Start everything normally
See that the
ThemeToggle
is show or hidden depending on the setting in thelocalhost
environment in launch darkly dashboard. If you toggle it there you will see the button hide and show automatically!Code review steps
As the original developer, I have
As code reviewer(s), I have
As a designer reviewer, I have
As a test user, I have