-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable dark mode toggle #859
Conversation
This pull request has been linked to Shortcut Story #1248: Launch darkly client id is not loading at run time. |
3043336
to
f8c9e16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only looked at the visuals (toggle theme on all pages) but looks good to me!
6bdb73e
to
4963a24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left one question, but I don't think it's blocking. I also ran e2e tests locally and they were all passing for me, so not sure why they keep failing here.
@@ -4,6 +4,9 @@ services: | |||
build: | |||
context: https://github.com/USSF-ORBIT/ussf-portal-cms.git#main | |||
dockerfile: Dockerfile | |||
target: e2e-local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does 'e2e-local' need to be hard coded here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I think it's okay here since we only ever use the docker-compose.cms.yml
when running things locally in docker via yarn cms:up
. If we started using this docker compose file elsewhere we would want to consider changing it like in USSF-ORBIT/ussf-portal#163. That PR is different since the E2E workflow uses docker compose to start up all the various services.
SC-1248
Proposed changes
This PR replaces #839 and merges in the developer work flow improvements. It also enables the
Reviewer notes
yarn dev
)yarn portal:up
See also updated docs indevelopment.md
filedevelopment.md
Reviewer notes
Per our discussions we are aiming to release DarkMode at the end of the iteration. This pr does that and removes the launch darkly stuff.
Setup
Typical
yarn services:up
andyarn dev
in cms and client reposCode review steps
As the original developer, I have
As code reviewer(s), I have
As a designer reviewer, I have
As a test user, I have
Screenshots