Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add USSF Guardian Commitment Poster to docs page #888

Merged
merged 2 commits into from
Dec 13, 2022
Merged

feat: add USSF Guardian Commitment Poster to docs page #888

merged 2 commits into from
Dec 13, 2022

Conversation

gidjin
Copy link
Contributor

@gidjin gidjin commented Dec 13, 2022

SC-1450

Add the new USSF Guardian Commitment Poster pdf to the documents page

Proposed changes

PDF added and link added to documents page

Reviewer notes

None

Setup

  • yarn services
  • yarn dev
  • cd path/to/cms && yarn dev

Navigate to http://localhost:3000/ussf-documentation and see the new link and file

Code review steps

As the original developer, I have

  • Met the acceptance criteria, or will meet them in subsequent PRs or stories
    • ...
  • Created new stories in Storybook if applicable
    • Checked that all Storybook accessibility checks are passing
  • Created/modified automated unit tests in Jest
    • Including jest-axe checks when UI changes
  • Created/modified automated E2E tests in Cypress
    • Including cypress-axe checks when UI changes
    • Checked that the E2E test build is not failing
  • Performed a11y testing:
    • Checked responsiveness in mobile, tablet, and desktop
    • Checked keyboard navigability
    • Tested with VoiceOver in Safari
    • Checked VO's rotor menu for landmarks, page heading structure and links
    • Used a browser a11y tool to check for issues (WAVE, axe, ANDI or Accessibility addon tab for Storybook)
  • Requested a design review for user-facing changes
  • For any new migrations/schema changes:
    • Followed guidelines for zero-downtime deploys

As code reviewer(s), I have

  • Pulled this branch locally and tested it
  • Reviewed this code and left comments
  • Checked that all code is adequately covered by tests
    • Checked that the E2E test build is not failing
  • Made it clear which comments need to be addressed before this work is merged
  • Considered marking this as accepted even if there are small changes needed
  • Performed a11y testing:
    • Checked responsiveness in mobile, tablet, and desktop
    • Checked keyboard navigability
    • Tested with VoiceOver in Safari
    • Checked VO's rotor menu for landmarks, page heading structure and links
    • Used a browser a11y tool to check for issues (WAVE, axe, ANDI or Accessibility addon tab for Storybook)

As a designer reviewer, I have

  • Checked in the design translated visually
  • Checked behavior
  • Checked different states (empty, one, some, error)
  • Checked for landmarks, page heading structure, and links
  • Tried to break the intended flow
  • Performed a11y testing:
    • Checked responsiveness in mobile, tablet, and desktop
    • Checked keyboard navigability
    • Tested with VoiceOver in Safari
    • Checked VO's rotor menu for landmarks, page heading structure and links
    • Used a browser a11y tool to check for issues (WAVE, axe, ANDI or Accessibility addon tab for Storybook)

As a test user, I have

  • Run through the Test Script:
    • On commercial internet in IE11
    • On commercial internet in Firefox
    • On commercial internet in Chrome
    • On commercial internet in Safari
    • On NIPR in IE11
    • On NIPR in Firefox
    • On NIPR in Chrome
    • On NIPR in Safari
    • On a mobile device in Firefox
    • On a mobile device in Chrome
    • On a mobile device in Safari
  • Added any anomalous behavior to this PR

Screenshots

SCR-20221213-gcx

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #1450: Upload Guardian Commitment poster to the documents page.

@gidjin gidjin merged commit 07fb472 into main Dec 13, 2022
@gidjin gidjin deleted the sc-1450/add-guardian-commitment-to-docs-page branch December 13, 2022 20:09
@gidjin gidjin mentioned this pull request Dec 13, 2022
Merged
gidjin added a commit that referenced this pull request Dec 13, 2022
@gidjin
chore(release): 4.12.0 (#890)
026af9c 
## [4.12.0](4.10.0...4.12.0) (2022-12-13)


### Features

* Add support for hero image in articles ([#862](#862)) ([56721db](56721db))
* add USSF Guardian Commitment Poster to docs page ([#888](#888)) ([07fb472](07fb472))
* Create USSF Documentation page ([#860](#860)) ([6c5d6b3](6c5d6b3))
* Display hero image in article layout ([#884](#884)) ([b2201ac](b2201ac))
* UI modifications to the article template ([#856](#856)) ([dc7402c](dc7402c))


### Bug Fixes

* **deps:** update dependency axios to v1 ([#851](#851)) ([de30320](de30320))


### Security Improvements

* **deps:** update node.js to v14.21.1 ([#849](#849)) ([46aba91](46aba91))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyoung abbyoung abbyoung approved these changes

@esacteksab esacteksab Awaiting requested review from esacteksab

@minhlai minhlai Awaiting requested review from minhlai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gidjin @abbyoung