fix: Styling on GovBanner makes text hard to read #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #414: Black on black text in the US Govt sliver at the top of the page. |
gidjin
force-pushed
the
sc-414/fix-styling-govbanner
branch
from
4034a0c to
61f67a6
Compare
abbyoung
approved these changes
Apr 17, 2023
…nstead of in the gov banner styling
…nstead of in the gov banner styling
gidjin
force-pushed
the
sc-414/fix-styling-govbanner
branch
from
50bdfe9 to
2992ef0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-414
Proposed changes
It's hard to read the
GovBannertext with our current styling, this PR fixes it and adds the component to Storybook.Reviewer notes
The chevron seems to be missing in our version of the GovBanner, I asked Design to see if they can help identify why.
Setup
You can view the new fixed style in storybook
http://localhost:6006/?path=/story/base-govbanner--default
or in the app
yarn services:up yarn dev cd ../ussf-portal-cms yarn devCheck Login page, My space, and http://localhost:3000/500 for error layout.
Screenshots
NOTE I show the expanded view which isn't visible until you click the
Here's how you knowlinkLogin page
GovBannerError page
GovBannerDefault page
GovBanner