Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update pr templates #999

Merged
merged 6 commits into from
Apr 19, 2023
Merged

docs: update pr templates #999

merged 6 commits into from
Apr 19, 2023

Conversation

gidjin
Copy link
Contributor

@gidjin gidjin commented Apr 18, 2023

SC-1901

Proposed changes

Applying the changes to the template that we discussed. The PR https://github.com/USSF-ORBIT/ussf-portal/pull/261 adds more detailed documentation on the template usage.

Reviewer notes

Let me know if I missed anything, have any typos, or if there is some better way to lay this out.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #1901: Update PR template and related process docs.

@gidjin gidjin marked this pull request as ready for review April 18, 2023 16:21
@gidjin gidjin requested a review from a team as a code owner April 18, 2023 16:21
Copy link
Contributor

@minhlai minhlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better!

@gidjin gidjin merged commit 365fab8 into main Apr 19, 2023
@gidjin gidjin deleted the sc-1901/docs-update-pr-template branch April 19, 2023 22:12
@gidjin gidjin mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants