Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device command to delete BLE data #1029

Closed
mondalaci opened this issue Dec 15, 2024 · 8 comments · Fixed by #1082
Closed

Add device command to delete BLE data #1029

mondalaci opened this issue Dec 15, 2024 · 8 comments · Fixed by #1082
Assignees

Comments

@mondalaci
Copy link
Member

It must be possible to delete BLE data from the settings partition.

BLE pairing between the halves should be preserved. Everything else should be removed from the settings partition.

@kareltucek This is a blocking issue, so please make it a priority.

@mondalaci
Copy link
Member Author

I've been thinking about whether this issue is justified.

If the firmware ensures that the settings partition only contains data that is associated to host connections and automatically deletes the rest of the data and the bond between the halves every time upon saves, then this issue has no purpose.

@kareltucek What do you think?

@kareltucek
Copy link
Collaborator

I think it is not necessary, but no trouble implementing it. (Actually, it is already waiting for me to test it before openin g PR.)

@mondalaci
Copy link
Member Author

If it's redundant, given the firmware's behavior regarding handling the host connection deletions, it makes no sense to have this command.

@kareltucek
Copy link
Collaborator

👍

@mondalaci mondalaci reopened this Jan 4, 2025
@mondalaci
Copy link
Member Author

I'm reopening this issue because it would be useful for troubleshooting purposes.

@kareltucek Please elaborate on the suggested implementation. Maybe the most surefire way would be to wipe the settings partitions and re-pair the halves afterward.

@mhantsch
Copy link
Contributor

mhantsch commented Jan 4, 2025

What else is on the settings partition? I mean, this issue literally just asks about clearing the BLE pairing info.

@mhantsch
Copy link
Contributor

mhantsch commented Jan 4, 2025

If you clear everything, then it's more like "factory reset everything", isn't it?

@mondalaci
Copy link
Member Author

The settings partition only contains wireless connectivity information, mainly security keys and BLE addresses.

The user configuration is on a different partition, and I'd handle the two separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants