-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic battery manager. #1142
base: master
Are you sure you want to change the base?
Conversation
This isn't tested very well yet. |
Known issues:
|
The code looks very good and well abstracted. If the charger is disconnected, what policy will you implement for |
For empty, uhk shuts down (as deep as I can make it). Almost empty is just an auxiliarry region that makes sure that the keyboard doesnt oscillate between power on and off. I am not displaying anything at the moment. |
Sounds reasonable.
|
I am not strictly against introducing the warning, but I would prefer to split into a separate issue (I am already writing another code on top of this, am not sure where to render it, and am not even sure we need it)... |
I think this is ready for merge. |
Actually, not yet. Half will not wake up if restarted 🤦. |
d889ffa
to
c750657
Compare
Solves the most pressing issues of #974.
What it does:
What it does not do: