Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to make css classes for styling headings #1004

Open
hmpf opened this issue Nov 28, 2024 · 0 comments
Open

We need to make css classes for styling headings #1004

hmpf opened this issue Nov 28, 2024 · 0 comments
Assignees
Labels
CSS frontend Affects frontend

Comments

@hmpf
Copy link
Contributor

hmpf commented Nov 28, 2024

Agree with the comments above, furthermore putting it on <main> restricts max width to 65ch so a bad idea altogether.

Regarding the looks itself, I personally like the following compiled typography styles (for our headings system and for #171):

  • font size, line-height etc
  • all headings tags
  • strong

With such a little subset of relevant styles let's just add our own classes.

Although some typography plugin styles (for example for a) are better for accessibility in general but it's minor improvements and not worth adding the whole thing just because of it IMO.. :)

Originally posted by @podliashanyk in Uninett/argus-htmx-frontend#202 (comment)

@github-project-automation github-project-automation bot moved this to 📋 Backlog in HTMXify Argus Nov 28, 2024
@hmpf hmpf added frontend Affects frontend CSS labels Nov 28, 2024
@podliashanyk podliashanyk self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS frontend Affects frontend
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants