Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a query-parameter to incident list to filter on an existing Filter #244

Closed
Tracked by #121
hmpf opened this issue Jan 6, 2021 · 5 comments · Fixed by #684
Closed
Tracked by #121

Add a query-parameter to incident list to filter on an existing Filter #244

hmpf opened this issue Jan 6, 2021 · 5 comments · Fixed by #684
Assignees
Labels
API Affects Argus' REST API enhancement New feature or request filter Affects the Filter-model, incident list query parameters or both frontend Affects frontend priority: low

Comments

@hmpf
Copy link
Contributor

hmpf commented Jan 6, 2021

notificationprofile.Filter's primary key could be sent in via GET-parameter.

@hmpf hmpf added API Affects Argus' REST API enhancement New feature or request priority: high labels Jan 6, 2021
@lunkwill42
Copy link
Member

Security consideration here: If submitting a PK to a filter that does not belong to the current user, that should be an error

@hmpf
Copy link
Contributor Author

hmpf commented Jan 6, 2021

See also Uninett/Argus-frontend#173

@hmpf
Copy link
Contributor Author

hmpf commented Jan 6, 2021

The more I think about this, the better an idea it is. Querystrings are bookmarkable, so we don't need to store it on the user or set a cookie!

@hmpf
Copy link
Contributor Author

hmpf commented Jan 6, 2021

Adding the param itself is not hard, hooking it up to the list is harder. I think it is all methods on either Filter or NotificationFilter.

@hmpf hmpf added the frontend Affects frontend label Jan 6, 2021
@hmpf hmpf added notification Affects the notification system filter Affects the Filter-model, incident list query parameters or both and removed notification Affects the notification system labels Jan 20, 2021
@katsel
Copy link
Contributor

katsel commented Jan 21, 2021

This change is not urgently needed in the frontend, because frontend does filtering on its own. So this is nice to have / low-priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Affects Argus' REST API enhancement New feature or request filter Affects the Filter-model, incident list query parameters or both frontend Affects frontend priority: low
Projects
None yet
4 participants