Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argus notification e-mails should provide a fully qualified details URL, not a relative URI #744

Closed
lunkwill42 opened this issue Apr 9, 2024 · 0 comments · Fixed by #794
Assignees
Labels
bug Something is not working as expected

Comments

@lunkwill42
Copy link
Member

Received e-mail

I receive e-mail notifications that look like this (slightly anonymized):

Status: STA
Actor: lokalnav.example.org

start_time       : 2024-02-28 14:46:30.759826+01:00

end_time         : 9999-12-31 23:59:59.999999+01:00

source_incident_id: 227463

details_url      : /search/event/227463
 
description      : example-fw1 BGP session with example-fw2 (fe80:6969:3232:1::10) is administratively DOWN

level            : 3

ticket_url       : 

search_text      : 

Expected behaviour

I would expect that "details_url" in this e-mail would be formatted as https://lokalnav.example.org/search/event/227463 (based on the configured base url of the source system in question), which would make a copy&pastable link at worst, and a clickable link at best (depending on your e-mail client).

I would really also expect the end_time to be formatted as something more readable, like "still open" or something, but that should be another issue, I guess.

Actual behaviour

Instead, this happened: I got a useless /search/event/227463 link and I need to do multiple copy&paste operations in order to browse the proper details page of the source system.

@lunkwill42 lunkwill42 added the bug Something is not working as expected label Apr 9, 2024
@johannaengland johannaengland self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants