Use gunicorn and uvicorn in Docker production image #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #766 +/- ##
==========================================
+ Coverage 78.96% 78.99% +0.02%
==========================================
Files 74 74
Lines 3628 3637 +9
==========================================
+ Hits 2865 2873 +8
- Misses 763 764 +1 ☔ View full report in Codecov by Sentry. |
hmpf
approved these changes
Apr 23, 2024
This way, the container commadn arguments can be passed directly to gunicorn to modify its behavior, such as adding more workers or changing the log level.
gunicorn+uvicorn should be more suitable for production use. uvicorn is used to provide an ASGI interface so the Argus API websockets implementation will work (except that it doesn't work really well in its current implementation)
hmpf
force-pushed
the
docker/use-gunicorn-and-uvicorn-in-docker
branch
from
583dee2 to
8beab5c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gunicorn+uvicorn should be more suitable for production use. uvicorn is used to provide an ASGI interface so the Argus API websockets implementation will work (except that it doesn't work really well in its current implementation)
This is closer to our current production deployment image, which we hope to replace with our official image from this repo.