Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to delete incidents #804

Closed
elfjes opened this issue May 3, 2024 · 4 comments · Fixed by #805
Closed

Ability to delete incidents #804

elfjes opened this issue May 3, 2024 · 4 comments · Fixed by #805

Comments

@elfjes
Copy link
Collaborator

elfjes commented May 3, 2024

The Geant correlator may create temporary incidents that are initially shown to the NOC. After some time the correlator may have discovered a (different) root cause of these incidents and they need to be replaced by a new incidents. The temporary incidents should be fully deleted from argus (ie. not closed or archived) as they have lost all relevance at that point.

@hmpf hmpf transferred this issue from Uninett/argus-htmx-frontend May 6, 2024
@hmpf hmpf moved this from 📋 Backlog to 🔖 Ready in HTMXify Argus May 6, 2024
@hmpf
Copy link
Contributor

hmpf commented May 6, 2024

I will start by adding the capability to unconditionally delete an incident. It should depend on some other flag on the incident but we need to settle on a name. We could also have it depend on the age of the incident (x seconds since start_time and it is still deletable) but then we should have a setting to set that magical time wondow, which also needs a name.

@hmpf
Copy link
Contributor

hmpf commented May 6, 2024

Potential names for new field on incident:

  • new, default=True. Toggle on ack/close/other?
  • stable, default=True. Toggle on ack/close/other?

@hmpf
Copy link
Contributor

hmpf commented May 6, 2024

There is also the client-library at https://github.com/Uninett/pyargus. @elfjes are you using this or using the API directly?

@elfjes
Copy link
Collaborator Author

elfjes commented May 6, 2024

I can imagine that you want to limit the ability to delete issues for regular users through the ui (probably not even want to expose this functionality through the ui). But also for an admin user, using the api? I think it would be easier to just allow that and don't add additional complexity until it's really needed?

There is also the client-library at https://github.com/Uninett/pyargus. @elfjes are you using this or using the API directly?

I'm not quite sure what the status of this library is, given that the last commit is over 2 years ago. If you say it's still supported we might want to use it, but if not it's not a big deal. For now we only have to query a few endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants