Allow updating Incident.metadata #807
Conversation
There was a problem hiding this comment.
We have no strong use case (yet) for tracking all changes to metadata for a given incident.
Having said that. I think it makes more sense if a change in metadata only results in a single ChangeEvent, one for all additions, removal and changes.
Also I expect quite some nesting in our metadata (at least more than just a flat dictionary) so most thing would fall under a metadata "change" even if we're mostly adding data (eg. to a nested array), which would warrant looking up changes recursively, but then you're even more over engineering :D
|
Yeah I'll be treating metadata very hands off for now. I really want to add a OneToOne table depending on Noodling with metadata did allow my subconscious to come up with something uncomplicated for deletion of incidents though, as I hoped. |
|
See also #808 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
=======================================
Coverage 84.48% 84.48%
=======================================
Files 76 76
Lines 3802 3803 +1
=======================================
+ Hits 3212 3213 +1
Misses 590 590 ☔ View full report in Codecov by Sentry. |
|
I'll split this into two PR's, one for altering metadata and one for DRY-ing change events, but review this one as is anyway. |
|
Possibly overengineered.