Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always format ChangeEvent descriptions the same way #809

Merged
merged 2 commits into from
May 8, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented May 7, 2024

Closes #808

@hmpf hmpf requested review from a team May 7, 2024 12:37
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf
Copy link
Contributor Author

hmpf commented May 7, 2024

Polish: stop testing the actual contents of the change description in every, single, test. Add some tests just for the formatter.

Copy link

github-actions bot commented May 7, 2024

Test results

       4 files     336 suites   12m 2s ⏱️
   469 tests    468 ✔️ 1 💤 0
1 876 runs  1 872 ✔️ 4 💤 0

Results for commit 4ebf310.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@hmpf hmpf merged commit 05d26f0 into Uninett:master May 8, 2024
10 checks passed
@hmpf hmpf deleted the fix-change-events branch May 8, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor: Fix change-events so that change-string is only defined once
2 participants