[GEANT] Cannot change incident description

[elfjes]

During our PENDING phase, an incident's description may change. We would like to update an Incident's description in Argus. Currently this is not allowed as per:

Argus/src/argus/incident/serializers.py

Lines 174 to 187 in 05d26f0

	class IncidentPureDeserializer(serializers.ModelSerializer):
	EDITABLE_FIELDS = set(["ticket_url", "details_url", "level", "metadata"])
	tags = IncidentTagRelationSerializer(many=True, write_only=True)
	class Meta:
	model = Incident
	fields = [
	"tags",
	"details_url",
	"ticket_url",
	"level",
	"metadata",
	]

We would like this to be changed so that we can update an Incident description

[elfjes]

We have discussed that we could put our description in the metadata instead of making use of the Argus' provided Incident.description field. This is indeed a possibility but I'm a little bit reluctant to using it as I'm not quite sure how many places in the (upcoming) UI the description field might be used (which we would have to substitute for our metadata.description). And then the number of places may grow in the future as the UI evolves. I fear that this may lead to a reduced maintainablity on our side.

So I'd very much prefer it if Incident.description becomes an editable field. Or if that is not possible, that we (on our side) can change the render context for any template that uses description to show our specified Incident.metadata.description instead of the (default) incident.description

[lunkwill42]

I see no reason why incident descriptions could not be editable, as long as we follow the established pattern of logging a change event that describes what changed and who did it.