Prefetch related data in incidents endpoint #837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incidents endpoint does not appear to prefetch tag data when querying incidents. This may cause the response to be magnitudes slower that it needs to be.
For context, fetching 2.5K incidents is 99% faster if tag data is prefetched:
The difference may not be as stark in the API endpoint itself, as most of the time there is spent serializing the data to JSON (DRF's ModelSerializer is reaally slow). Simply testing the API before and after applying this change seems to indicate only a 36% speedup (which is still significant).