Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for UI/UX for timeslots #984

Open
hmpf opened this issue Sep 9, 2024 · 5 comments
Open

Idea for UI/UX for timeslots #984

hmpf opened this issue Sep 9, 2024 · 5 comments
Labels
ddn Design decision needed discussion Requires developer feedback/discussion before implementation

Comments

@hmpf
Copy link
Contributor

hmpf commented Sep 9, 2024

image

We can use checkboxes (one per hour) in a table or css grid.

@hmpf hmpf added after-demo Need not work for demo and removed after-demo Need not work for demo labels Sep 9, 2024
@hmpf
Copy link
Contributor Author

hmpf commented Sep 13, 2024

This will mean it won't be possible to have shorter than one hour intervals of (not) sending notifications.

Proddata:

 count |  start   
-------+----------
     1 | 10:00:00
     1 | 15:00:00
     1 | 16:00:00
     1 | 09:00:00
     1 | 07:20:00
     3 | 07:00:00
     4 | 08:00:00
    93 | 00:00:00

 count |       end       
-------+-----------------
     1 | 08:00:00
     1 | 20:00:00
     1 | 14:30:00
     1 | 23:59:00
     2 | 22:00:00
     3 | 23:00:00
     4 | 16:00:00
    92 | 23:59:59.999999

@hmpf
Copy link
Contributor Author

hmpf commented Sep 13, 2024

The end time == 14:30 is mine, as a test.

I will ask the owner of start time == 07:20 how important that level of precision is.

@hmpf
Copy link
Contributor Author

hmpf commented Sep 13, 2024

Owner of the 0720 start time won't mind whole hours precision.

@hmpf
Copy link
Contributor Author

hmpf commented Sep 13, 2024

While making the statistics I discovered that "end" is magic in postgres. (It is not possible to write SELECT end FROM argus_notificationprofile_timerecurrence;, you get a syntax error. SELECT start FROM argus_notificationprofile_timerecurrence; works fine.)

Maybe we should consider changing "end" to "endtime" and "start" to "starttime" in the database schema.

@hmpf
Copy link
Contributor Author

hmpf commented Sep 13, 2024

This is probably why: https://www.postgresql.org/docs/current/sql-end.html

@hmpf hmpf transferred this issue from Uninett/argus-htmx-frontend Nov 28, 2024
@lunkwill42 lunkwill42 added discussion Requires developer feedback/discussion before implementation ddn Design decision needed labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ddn Design decision needed discussion Requires developer feedback/discussion before implementation
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants