Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lockers to resolve deltas on behalf of other lockers #366

Closed
snreynolds opened this issue Oct 12, 2023 · 1 comment
Closed

Allow lockers to resolve deltas on behalf of other lockers #366

snreynolds opened this issue Oct 12, 2023 · 1 comment
Assignees
Labels
p0 Very important to fix

Comments

@snreynolds
Copy link
Member

Component

Lock and Call

Describe the suggested feature and problem it solves.

To add more flexibility for lockers and open up new use cases, this idea would be to introduce a new way to pay off deltas by adding the ability for a locker to resolve open deltas on behalf of a different locker.

Describe the desired implementation.

Add a function resolve that nets out two lockers' deltas. Additionally, add the option for a locker to specify a "resolver" address. An initial proof of concept was explored here, along with a hook that could NoOp swaps/modifyPositions to show the Custom Accounting use case.

Describe alternatives.

No response

Additional context.

No response

@snreynolds snreynolds added triage p0 Very important to fix and removed triage labels Oct 12, 2023
@snreynolds snreynolds self-assigned this Oct 17, 2023
@snreynolds snreynolds mentioned this issue Nov 14, 2023
@ewilz
Copy link
Member

ewilz commented Jan 31, 2024

the balanceDelta's returned by all functions basically become moot with this, correct? Bc accountDeltas could be completely different the the balanceDeltas returned to callers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0 Very important to fix
Projects
None yet
Development

No branches or pull requests

3 participants