Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Modify Hooks.Calls into Hooks.Permissions #87

Closed
LiRiu opened this issue Dec 13, 2023 · 2 comments · Fixed by #74
Closed

[Bug]: Modify Hooks.Calls into Hooks.Permissions #87

LiRiu opened this issue Dec 13, 2023 · 2 comments · Fixed by #74
Labels
bug Something isn't working

Comments

@LiRiu
Copy link

LiRiu commented Dec 13, 2023 •
edited
Loading

Describe the bug

v4-core was updated.
struct Hooks.Calls has been modified into Hooks.Permissions
If not modified, the BaseHook.sol may not be able to compile.

Expected Behavior

compile complete.

To Reproduce

No response

Additional context

No response
@LiRiu LiRiu added the bug Something isn't working label Dec 13, 2023
@hensha256
Copy link
Contributor

Hi! This is being updated in PR #74 ! That PR should be merged before the end of this week

@hensha256 hensha256 linked a pull request Dec 13, 2023 that will close this issue
Update v4 core #74
Merged
@LiRiu
Copy link
Author

LiRiu commented Dec 13, 2023

Thanks, Looking forward to it very much.

@LiRiu LiRiu closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update v4 core Uniswap/v4-periphery
2 participants
@hensha256 @LiRiu