Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some messages are hardcoded in places other than messages.h #94

Open
MattWindsor91 opened this issue Mar 8, 2015 · 2 comments
Open

Comments

@MattWindsor91
Copy link
Member

Implies that either they should be moved, or messages.h should be removed.

@wlcx
Copy link
Contributor

wlcx commented Mar 23, 2015

Pros and cons to each approach?

@LordAro
Copy link
Member

LordAro commented Sep 21, 2016

I do like messages.h being a thing, but I also see scope for there being "literal" messages that are too specific for the file, like from each audio source.

With that in mind, the only message that I think should be merged into messages.h is "Unknown file format" from player.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants